move download logs button, switch between raw and normal logs #22721

bramkragten · 2024-11-07T13:48:41Z

Proposed change

Align the different log views, allow to toggle between them, no longer showing both on the same page.

Replaces #22717

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature (thank you!)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example configuration

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue or discussion:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
There is no commented out code in this PR.
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

coderabbitai · 2024-11-07T13:48:50Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

src/panels/config/logs/error-log-card.ts

home-assistant · 2024-11-07T15:56:57Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

wendevlin · 2024-11-07T18:53:19Z

src/panels/config/logs/system-log-card.ts

+                    <ha-icon-button
+                      .path=${mdiDownload}
+                      @click=${this._downloadLogs}
+                      .label=${this.hass.localize(
+                        "ui.panel.config.logs.download_logs"
+                      )}


We should also add the iOS fallback here, but we can do this in a seperate PR

wendevlin · 2024-11-07T18:55:32Z

@bramkragten the PR was still in a draft, I assume because it was automatically done by the bot. But I won't merge it in case you want to make any additional changes.

home-assistant bot added the cla-signed label Nov 7, 2024

bramkragten added this to the 2024.11 milestone Nov 7, 2024

github-actions bot added the Supervisor Related to the supervisor panel label Nov 7, 2024

wendevlin requested changes Nov 7, 2024

View reviewed changes

src/panels/config/logs/error-log-card.ts Outdated Show resolved Hide resolved

home-assistant bot marked this pull request as draft November 7, 2024 15:56

bramkragten added 3 commits November 7, 2024 17:05

move download logs button, switch between raw and normal logs

142d869

fixes and improvements

1f62cab

Update error-log-card.ts

d453511

bramkragten force-pushed the move-download-logs-button,-switch-between-raw-and-normal-logs branch from 54078ec to d453511 Compare November 7, 2024 16:06

wendevlin marked this pull request as ready for review November 7, 2024 18:47

home-assistant bot requested a review from wendevlin November 7, 2024 18:47

wendevlin approved these changes Nov 7, 2024

View reviewed changes

bramkragten merged commit 9f55ef8 into dev Nov 7, 2024
15 checks passed

bramkragten deleted the move-download-logs-button,-switch-between-raw-and-normal-logs branch November 7, 2024 20:32

bramkragten added the cherry-picked label Nov 7, 2024

bramkragten added a commit that referenced this pull request Nov 7, 2024

move download logs button, switch between raw and normal logs (#22721)

3873927

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move download logs button, switch between raw and normal logs #22721

move download logs button, switch between raw and normal logs #22721

bramkragten commented Nov 7, 2024

coderabbitai bot commented Nov 7, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

home-assistant bot commented Nov 7, 2024

wendevlin Nov 7, 2024

wendevlin commented Nov 7, 2024

move download logs button, switch between raw and normal logs #22721

move download logs button, switch between raw and normal logs #22721

Conversation

bramkragten commented Nov 7, 2024

Proposed change

Type of change

Example configuration

Additional information

Checklist

coderabbitai bot commented Nov 7, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

home-assistant bot commented Nov 7, 2024

wendevlin Nov 7, 2024

Choose a reason for hiding this comment

wendevlin commented Nov 7, 2024

CodeRabbit Configuration File (`.coderabbit.yaml`)